Bug/fix hybrid tp dp #38
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
3outeille
commented
Nov 20, 2023
•
3outeille
commented
- EDIT:
- Found out fairscale has the same bug as us => https://github.com/xrsrke/megatron-tp . Issue is put on hold
- Main contributions:
- TP convergence work (cf wandb log)
- DP + TP + Zero1 convergence work (cf wandb log)
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
3outeille
force-pushed
the
bug/fix-hybrid-tp-dp-clean
branch
6 times, most recently
from
aedf5c5
to
28ff9bf
Compare
3outeille
force-pushed
the
bug/fix-hybrid-tp-dp-clean
branch
from
28ff9bf
to
0d11a2b
Compare
3outeille
force-pushed
the
bug/fix-hybrid-tp-dp-clean
branch
from
0d11a2b
to
6bfa6a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.