-
-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle Apple Studio Display Brightness #748
base: master
Are you sure you want to change the base?
Conversation
This is great, thank you! I'll review this in more detail over the weekend, but at a glace it's a solid start. Ideally, we would want to match the USB connection with the display ID in Windows (e.g. |
Can you explain what the individual values are in that string? I'm not sure what they would correspond to in the USB protocol. Or why the code sometimes uses It seems |
I dug through WMI and the USB interface trying to associate them. But the monitor's information doesn't match the USB interfaces information, so there doesn't seem to be a way. I could just guess and assign monitors that have the I think it'd be safer to stick with the serial number as |
Took me a little longer than expected to dig into this, but I think this is good enough to merge in. I'll make some additions/adjustments when I work it into v1.16.0. Apple Studio Display users won't get access to all of the Twinkle Tray features, but that's better than not having it work at all. Thanks again for the PR! I'll tag you in the v1.16.0 beta issue when I have a build ready, if you don't mind testing. |
This uses studio-display-control to communicate with an Apple Studio Display via usb. I basically just ported over https://github.com/juliuszint/asdbctl into a node package.
I'm kinda abusing the serial number to uniquely identify the display. I don't have any DDC/CI displays, so I'm not really sure what the
key
andid
values are supposed to be in the normal paths. I also don't know how to support renaming the display, but I'm happy to update if you can tell me how.Fixes #705
Fixes #713
Fixes #489