-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft: Add CMake build system #310
Conversation
For some reason the linking works fine on all Linux compilers but fails on the |
Do you mean this problem with cmake ? |
I don't use cmake either, but if a PR provides a fully working cmake script, then it will be welcomed as for sure many people may prefer cmake over makefile/zig. On the other hand, webui is simple, one |
I suggest providing Thank you @NicolasBFR for this PR by the way 👍 |
I just wanted to make sure it would technically work for all platforms, unfortunately there is a linker error and I have no Mac or Windows installation to debug it. CMake is obviously not necessary for a small project like this, but I needed it to import the webui target in a bigger project (AI inference application). It builds fine on Arch Linux and Ubuntu, should I remove the CI changes, squash history and remove the draft status of the PR ? |
Don't worry, we need to wait @hassandraga for a decision |
New CMakeLists.txt to let users build the libraries using CMake Build CivetWeb and then use it to build WebUI
This is really not transparent from reading the README tbh. If using WebUI is as simple as adding a single .c file in a project, I would suggest this to be advertised in the README instead of only showing an opinionated build process. That would likely refrain many people from thinking "ok, where is the CMakeFile" or whetever other build system they want to use. |
Thank you @NicolasBFR for the PR. Yes, Adding CMake to WebUI is necessary for projects that use already CMake. This task was already in my todo list, so thank you for starting that.
Me neither, but I use it daily to avoid being fired. What can we do?!.
This is wrong, but it's one header file.
Readme says
Any suggestion is very welcome. |
Add CMake build system
New CMakeLists.txt to let users build the libraries using CMake
Build CivetWeb and then use it to build WebUI