Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply album artist when processing metadata #4247

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

everlyy
Copy link
Contributor

@everlyy everlyy commented Oct 30, 2023

This makes sure you're scrobbling the right album artist instead of the album artist always being set to the same artist as the current song, which is problematic when you're scrobbling a track that's in an album released as a 'Various Artists' album.

Describe the changes you made
I made sure the album artist is getting put as the album artist when an album is getting autofilled.

Additional context
Here's a before and after:
https://imgur.com/a/NA9NPVB

This makes sure you're scrobbling the right album artist instead of the
album artist always being set to the same artist as the current song,
which is problematic when you're scrobbling a track that's in an album
released as a 'Various Artists' album.
@inverse inverse added new-feature For PRs that add new functionality minor-change For minor changes labels Nov 4, 2023
Copy link
Member

@inverse inverse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes seem reasonable to me.

@yayuyokitano what do you think?

@yayuyokitano
Copy link
Member

Thank you for the contribution!

There are a couple of issues that will occur from this change.

  1. Some sites do not have a unique ID. In this case, a hash is generated from metadata to store edits. In these cases, edits users have set up will no longer work after this change.
  2. Unpredicted things could occur with regex edits as well.

For cases where this makes a meaningful improvement, I think it is a fine tradeoff.
However, please ensure that the album artist is not added when it is the same as the artist, as in this case there is no benefit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor-change For minor changes new-feature For PRs that add new functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants