Feat/test store improvements #4
Conversation
horvathtamasattila
force-pushed
the
feat/test-store-improvements
branch
from
b29a437
to
f669160
Compare
| Lens.id(), | ||
| Prism.id(), | ||
| testDispatcher | ||
| ) |
There was a problem hiding this comment.
What would be the benefit of introducing create over the already existing invoke method? You should be able to instantiate it with TestStore(...) vs TestStore.create(...).
There was a problem hiding this comment.
When you mess up something while instantiating a test store (types or something), using invoke the error message is not clear (or non-existent). This was more like for debugging, but I can take it out.
There was a problem hiding this comment.
I would keep the API surface to a minimum for now and introduce new ones only if necessary. If we have concrete examples and better understand what's happening with invoke, we can reconsider create (or any alternatives).
|
|
||
|
|
||
| @kotlin.ExperimentalStdlibApi | ||
| @OptIn(kotlin.ExperimentalStdlibApi::class) |
There was a problem hiding this comment.
These should not be necessary, we are enabling usage of experimental APIs globally in build.gradle.kts.
Improvements of error logging for tests