Supports remote backup push from PostgreSQL 15 or later (#1385) #1595
Conversation
* In the streamFromPostgres method, CopyData case adds data receiving processing from pgsql version 15 or later. * In the streamFromPostgres method, add NoticeResponse case. * Troubleshoot EOF problems caused by the last zeroBlock message sent from pgsql15 or later. * Add test for Supports remote backup push from PostgreSQL 15 or later Signed-off-by: tangtx <tianxitang@harmonycloud.cn>
|
Can the code owner help me review the code? THX！ |
|
What needs to be done to get this reviewed and merged? We would like to use the remote backup feature for our PG15+ clusters, and would prefer not to maintain/run a fork. |
|
@debebantur Can you please take a look on the code? Architecturally the feature seem important. |
|
I agree with @x4m . The latest wal-g is no longer applicable to the remote backup capability of pgsql above version 15. Please take a look！ @Aevin1387 |
|
Hello, @tangtx3 ! There were some changes in wal-g since pr was last updated. For example some settings moved from internal to internal/config. Could you, please, rebase pr. |
| userData, err := internal.UnmarshalSentinelUserData(userDataRaw) | ||
| tracelog.ErrorLogger.FatalfOnError("Failed to unmarshal the provided UserData: %s", err) | ||
|
|
||
| folder, err := internal.ConfigureFolder() |
There was a problem hiding this comment.
Seems, that this err value is unused
| fullBackup, storeAllCorruptBlocks || viper.GetBool(internal.StoreAllCorruptBlocksSetting), | ||
| tarBallComposerType, NewRegularDeltaBackupConfigurator(deltaBaseSelector), | ||
| userData, withoutFilesMetadata) | ||
|
|
There was a problem hiding this comment.
And here err is not checked too
Database name
PostgreSQL
Pull request description
Supports remote backup push from PostgreSQL 15 or later (#1385)
Describe what this PR fix
Please provide steps to reproduce (if it's a bug)
wal-g backup-pushERROR: 2023/11/16 10:37:36.274535 unexpected response: &{%!t(string=ERROR) %!t(string=ERROR) %!t(string=42601) %!t(string=syntax error) %!t(string=) %!t(string=) %!t(int32=0) %!t(int32=0) %!t(string=) %!t(string=) %!t(string=) %!t(string=) %!t(string=) %!t(string=) %!t(string=) %!t(string=repl_scanner.l) %!t(int32=247) %!t(string=replication_yyerror) map[]}Please add config and wal-g stdout/stderr logs for debug purpose
test case！
AWS_ACCESS_KEY_ID=minio;
AWS_ENDPOINT=http://127.0.0.1:32009;
AWS_S3_FORCE_PATH_STYLE=true;
AWS_SECRET_ACCESS_KEY=123456;
PGHOST=127.0.0.1;
PGPASSWORD=123456;
PGPORT=5432;
PGUSER=postgres;
WALE_S3_PREFIX=s3://test-pg/pg15-1116