Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(PresetPanel): preset panel stopPropagation #7550

Merged
merged 1 commit into from
Jun 4, 2024
Merged

fix(PresetPanel): preset panel stopPropagation #7550

merged 1 commit into from
Jun 4, 2024
+2 −1

Conversation

evan-lc
Copy link
Contributor

@evan-lc evan-lc commented May 2, 2024

这个变动的性质是

  • 日常 bug 修复

需求背景

RangePicker在getPopupContainer设置为(el) => el.parentNode时，点击preset时会触发两次onOpenChange，第一次为preset panel，open为false，第二次为事件冒泡到onPickerClick，open为true

复现地址 https://stackblitz.com/edit/vitejs-vite-kjllhh?file=src%2Fcomponents%2FHelloWorld.vue 点击RangePicker，选择PresetPanel中的一个preset，日期选择面板消失后又出现

实现方案和 API（非新功能可选）

PresetPanel的onClick阻止事件冒泡

@tangjinzhou tangjinzhou merged commit b82d8dd into vueComponent:main Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@evan-lc @tangjinzhou