-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to robfig/cron/v3 to support time zone specification #7793
base: main
Are you sure you want to change the base?
Conversation
ef0df3c
to
c5ce523
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7793 +/- ##
=======================================
Coverage 58.66% 58.67%
=======================================
Files 345 345
Lines 28733 28739 +6
=======================================
+ Hits 16856 16862 +6
Misses 10448 10448
Partials 1429 1429 ☔ View full report in Codecov by Sentry. |
Please check the failed cases in the CI action. |
It's not failing locally... |
Breaking change (can be mitigated if needed in the future): v1 branch accepted an optional seconds field at the beginning of the cron spec. This is non-standard and has led to a lot of confusion. The new default parser conforms to the standard as described by [the Cron wikipedia page.](https://en.wikipedia.org/wiki/Cron). It is unlikely that this affects us per vmware-tanzu#31 Other notes: > CRON_TZ is now the recommended way to specify the timezone of a single schedule, which is sanctioned by the specification. The legacy "TZ=" prefix will continue to be supported since it is unambiguous and easy to do so. References: https://pkg.go.dev/github.com/robfig/cron/v3#readme-upgrading-to-v3-june-2019 Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
c5ce523
to
160a2e1
Compare
@blackpiglet looks like it was a flaky test |
Thanks. |
Sounds good. |
Not 1.14 target |
Thanks @kaovilai But this is optional since it's briefly covered in the Wikipedia link |
Breaking change (can be mitigated if needed in the future): v1 branch accepted an optional seconds field at the beginning of the cron spec. This is non-standard and has led to a lot of confusion. The new default parser conforms to the standard as described by the Cron wikipedia page.. It is unlikely that this affects us per #31
Other notes:
References: https://pkg.go.dev/github.com/robfig/cron/v3#readme-upgrading-to-v3-june-2019
Signed-off-by: Tiger Kaovilai tkaovila@redhat.com
Thank you for contributing to Velero!
Please add a summary of your change
Does your change fix a particular issue?
Fixes #7792
Please indicate you've done the following:
/kind changelog-not-required
as a comment on this pull request.site/content/docs/main
.