Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add volume backup result #7775

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

blackpiglet
Copy link
Contributor

@blackpiglet blackpiglet commented May 7, 2024

Thank you for contributing to Velero!

Please add a summary of your change

  • Add the result in the backup's VolumeInfo.
  • Add more prow actions.

Does your change fix a particular issue?

Fixes #7676

Please indicate you've done the following:

  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
  • Updated the corresponding documentation in site/content/docs/main.

@blackpiglet blackpiglet force-pushed the add_volume_backup_result branch 3 times, most recently from be7db71 to 1071dd2 Compare May 7, 2024 07:33
Copy link

codecov bot commented May 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.68%. Comparing base (3c37c84) to head (a6d501a).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7775      +/-   ##
==========================================
+ Coverage   58.66%   58.68%   +0.01%     
==========================================
  Files         344      344              
  Lines       28731    28744      +13     
==========================================
+ Hits        16854    16867      +13     
  Misses      10448    10448              
  Partials     1429     1429              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@blackpiglet blackpiglet force-pushed the add_volume_backup_result branch 3 times, most recently from 59ab1b4 to 8c85761 Compare May 7, 2024 11:14
@blackpiglet blackpiglet marked this pull request as ready for review May 8, 2024 07:26
@reasonerjt
Copy link
Contributor

Let's revisit to determine if it should target v1.14.1

@blackpiglet
Copy link
Contributor Author

/cc @reasonerjt

@github-actions github-actions bot requested a review from reasonerjt May 9, 2024 03:07
Signed-off-by: Xun Jiang <blackpigletbruce@gmail.com>
Signed-off-by: Xun Jiang <blackpigletbruce@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add volume result in backup's VolumeInfo
2 participants