Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove pkg/generated #7627

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

mateusoliveira43
Copy link
Contributor

@mateusoliveira43 mateusoliveira43 commented Apr 4, 2024

Please add a summary of your change

Deleted pkg/generated/ folder.

Does your change fix a particular issue?

Fixes #6190
Fixes openshift/oadp-operator#1221

Please indicate you've done the following:

  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
  • Updated the corresponding documentation in site/content/docs/main.

Copy link

codecov bot commented Apr 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.80%. Comparing base (a8d77ea) to head (1c950f6).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7627   +/-   ##
=======================================
  Coverage   58.80%   58.80%           
=======================================
  Files         345      345           
  Lines       28759    28759           
=======================================
  Hits        16911    16911           
  Misses      10420    10420           
  Partials     1428     1428           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mateusoliveira43
Copy link
Contributor Author

As @sseago commented with me "regarding removing pkg/generated, that was only deprecated in 1.13, so probably shouldn't remove it until 1.15 at the earliest" I am drafting this PR until it is time, but it should be good enough already, only codecov job failed...

@mateusoliveira43 mateusoliveira43 marked this pull request as draft April 4, 2024 14:40
@blackpiglet
Copy link
Contributor

The CI job failed with the codecov result uploading.
It's already fixed, please rebase to pick-up it.

@reasonerjt
Copy link
Contributor

Per discussion this will be merged post-v1.14

@blackpiglet
Copy link
Contributor

We can start to work on this PR because the release-1.14 branch was already cut.

Signed-off-by: Mateus Oliveira <msouzaol@redhat.com>
Signed-off-by: Mateus Oliveira <msouzaol@redhat.com>
Signed-off-by: Mateus Oliveira <msouzaol@redhat.com>
@mateusoliveira43 mateusoliveira43 marked this pull request as ready for review June 5, 2024 15:49
@mateusoliveira43
Copy link
Contributor Author

undrafted the PR

@blackpiglet
Copy link
Contributor

dcoapp/app#211 (comment)
The DCO check is blocked by this issue.
Please follow the above comment to push an empty commit to let the check pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants