testifylint: enable bool-compare rule #7623
Open
+33
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7623 +/- ##
=======================================
Coverage 58.79% 58.79%
=======================================
Files 345 345
Lines 28764 28764
=======================================
Hits 16911 16911
Misses 10425 10425
Partials 1428 1428 ☔ View full report in Codecov by Sentry. |
github-actions
bot
added
the
kind/changelog-not-required
anshulahuja98
previously approved these changes
Apr 10, 2024
|
/kind changelog-not-required |
blackpiglet
added
kind/changelog-not-required
mmorel-35
force-pushed
the
testifylint/bool-compare
branch
from
df2fbef
to
adcd293
Compare
|
I had to resolve conflicts |
mmorel-35
force-pushed
the
testifylint/bool-compare
branch
3 times, most recently
from
1d2e27a
to
8f18e79
Compare
mmorel-35
force-pushed
the
testifylint/bool-compare
branch
2 times, most recently
from
f4c76a6
to
daa0182
Compare
mmorel-35
force-pushed
the
testifylint/bool-compare
branch
from
daa0182
to
6f0aac7
Compare
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
mmorel-35
force-pushed
the
testifylint/bool-compare
branch
from
6f0aac7
to
7204af2
Compare
blackpiglet
approved these changes
May 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please add a summary of your change
testifylint: enable bool-compare rule
Does your change fix a particular issue?
No
Please indicate you've done the following:
/kind changelog-not-requiredas a comment on this pull request.site/content/docs/main.