Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: insert on duplicate update to add list argument in the bind variables map #15961

Merged
merged 3 commits into from
May 17, 2024

Conversation

harshit-gangal
Copy link
Member

@harshit-gangal harshit-gangal commented May 16, 2024

Description

This PR fixes the issue with insert on duplicate key update. When there is a list argument in the on duplicate key update expressions it was missed in sending down to vttablet.

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

…ables map

Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Copy link
Contributor

vitess-bot bot commented May 16, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels May 16, 2024
@harshit-gangal harshit-gangal added Type: Bug Component: Query Serving Type: Regression Backport to: release-18.0 Needs to be back ported to release-18.0 Backport to: release-19.0 Needs to be back ported to release-19.0 and removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels May 16, 2024
@github-actions github-actions bot added this to the v20.0.0 milestone May 16, 2024
@harshit-gangal harshit-gangal added NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request labels May 16, 2024
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Copy link

codecov bot commented May 17, 2024

Codecov Report

Attention: Patch coverage is 91.66667% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 68.48%. Comparing base (7997d1e) to head (9b2a0d7).

Files Patch % Lines
go/vt/vtgate/engine/insert.go 91.66% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #15961   +/-   ##
=======================================
  Coverage   68.47%   68.48%           
=======================================
  Files        1562     1562           
  Lines      197062   197069    +7     
=======================================
+ Hits       134933   134957   +24     
+ Misses      62129    62112   -17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@harshit-gangal harshit-gangal removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request labels May 17, 2024
@harshit-gangal harshit-gangal marked this pull request as ready for review May 17, 2024 09:32
@harshit-gangal harshit-gangal merged commit 3b1800d into vitessio:main May 17, 2024
94 of 95 checks passed
@harshit-gangal harshit-gangal deleted the insert-missing-bv branch May 17, 2024 11:08
vitess-bot pushed a commit that referenced this pull request May 17, 2024
…ables map (#15961)

Signed-off-by: Harshit Gangal <harshit@planetscale.com>
harshit-gangal added a commit that referenced this pull request May 17, 2024
…ables map (#15961)

Signed-off-by: Harshit Gangal <harshit@planetscale.com>
harshit-gangal added a commit that referenced this pull request May 17, 2024
…n the bind variables map (#15961) (#15966)

Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Co-authored-by: Harshit Gangal <harshit@planetscale.com>
harshit-gangal added a commit that referenced this pull request May 17, 2024
…n the bind variables map (#15961) (#15967)

Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
Co-authored-by: Harshit Gangal <harshit@planetscale.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backport to: release-18.0 Needs to be back ported to release-18.0 Backport to: release-19.0 Needs to be back ported to release-19.0 Component: Query Serving Type: Bug Type: Regression
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug Report: Insert on duplicate key update failing with missing bind var
3 participants