chore: move react from devDependency to dependency in design system starter template #8159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turbo-orchestrator
bot
added
area: examples
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
5 Ignored Deployments
|
|
@ghdtjgus76 is attempting to deploy a commit to the Vercel Team on Vercel. A member of the Team first needs to authorize it. |
mehulkar
reviewed
May 16, 2024
There was a problem hiding this comment.
I think this is correct, but @anthonyshew is the right person to ask. I'd almost want react to be a peerDep in a shared package, not a real dep.
anthonyshew
approved these changes
May 19, 2024
anthonyshew
requested changes
May 19, 2024
|
I reflected the changes! |
|
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I mentioned this in discussions, in the design system starter template, react was specified as a devDependency rather than a dependency.
It needs to be moved to dependencies.
#8156
Testing Instructions