Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create turbo-static for compile time graph analysis #8037

Merged
merged 1 commit into from
Jun 4, 2024
Merged

create turbo-static for compile time graph analysis #8037

merged 1 commit into from
Jun 4, 2024

Conversation

arlyon
Copy link
Contributor

@arlyon arlyon commented Apr 24, 2024 •
edited by padmaia

Description

Testing Instructions

Closes TURBO-2877

@vercel Vercel
Copy link

vercel bot commented Apr 24, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 4, 2024 3:14pm
rust-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 4, 2024 3:14pm
8 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Visit Preview Jun 4, 2024 3:14pm
examples-designsystem-docs ⬜️ Ignored (Inspect) Visit Preview Jun 4, 2024 3:14pm
examples-gatsby-web ⬜️ Ignored (Inspect) Visit Preview Jun 4, 2024 3:14pm
examples-kitchensink-blog ⬜️ Ignored (Inspect) Visit Preview Jun 4, 2024 3:14pm
examples-native-web ⬜️ Ignored (Inspect) Visit Preview Jun 4, 2024 3:14pm
examples-svelte-web ⬜️ Ignored (Inspect) Visit Preview Jun 4, 2024 3:14pm
examples-tailwind-web ⬜️ Ignored (Inspect) Visit Preview Jun 4, 2024 3:14pm
examples-vite-web ⬜️ Ignored (Inspect) Visit Preview Jun 4, 2024 3:14pm

This was referenced Apr 24, 2024
Merged
Merged
Closed
@arlyon Graphite App
Copy link
Contributor Author

arlyon commented Apr 24, 2024 •
edited

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @arlyon and the rest of your teammates on Graphite Graphite

@arlyon arlyon mentioned this pull request Apr 24, 2024
Open
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 24, 2024 •
edited

🟢 Turbopack Benchmark CI successful 🟢

Thanks

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 24, 2024 •
edited

⚠️ CI failed ⚠️

The following steps have failed in CI:

  • Turbopack Rust tests (mac/win, non-blocking)

See workflow summary for details

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 24, 2024 •
edited

✅ This change can build next-swc

@arlyon arlyon force-pushed the 03-08-feat_add_mechanism_to_bypass_turbo_engine_for_annotated_methods branch from 9f50dd4 to d49e885 Compare May 15, 2024 11:25
@arlyon arlyon force-pushed the 03-08-feat_add_mechanism_to_bypass_turbo_engine_for_annotated_methods branch from d49e885 to fbab81c Compare May 15, 2024 15:25
@arlyon arlyon force-pushed the 03-08-feat_add_mechanism_to_bypass_turbo_engine_for_annotated_methods branch from fbab81c to 739c4e3 Compare May 15, 2024 15:27
@arlyon arlyon force-pushed the 03-08-feat_add_mechanism_to_bypass_turbo_engine_for_annotated_methods branch from 739c4e3 to 2671771 Compare May 16, 2024 08:06
bgw
bgw reviewed May 22, 2024
View reviewed changes
Copy link
Member

@bgw bgw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple quick comments about fjall and neo4j as I skimmed over this.

crates/turbo-static/readme.md Outdated Show resolved Hide resolved
crates/turbo-static/src/call_resolver.rs Outdated Show resolved Hide resolved
@arlyon arlyon force-pushed the 03-08-add_ability_to_filter_by_value_and_occurences branch from 003b9b0 to f0c3166 Compare May 29, 2024 16:50
@arlyon arlyon force-pushed the 03-08-add_ability_to_filter_by_value_and_occurences branch from f0c3166 to 1b49d92 Compare May 31, 2024 17:50
bgw
bgw approved these changes May 31, 2024
View reviewed changes
crates/turbo-static/src/identifier.rs Show resolved Hide resolved
crates/turbo-static/src/lsp_client.rs Outdated Show resolved Hide resolved
crates/turbo-static/src/visitor.rs Outdated Show resolved Hide resolved
Base automatically changed from 03-08-add_ability_to_filter_by_value_and_occurences to main June 4, 2024 12:45
@arlyon arlyon merged commit 0bf9e11 into main Jun 4, 2024
55 of 56 checks passed
@arlyon arlyon deleted the arlyon/turbo-static branch June 4, 2024 15:36
@arlyon Graphite App
Copy link
Contributor Author

arlyon commented Jun 4, 2024

Merge activity

@kdy1 kdy1 mentioned this pull request Jun 5, 2024
Merged
kdy1 added a commit to vercel/next.js that referenced this pull request Jun 5, 2024
@kdy1
feat(turbopack): Introduce RcStr (#66262)
3cf225c 
# Turbopack

* vercel/turbo#8272 <!-- Donny/강동윤 - feat:
Update `swc_core` to `v0.92.8` -->
* vercel/turbo#8262 <!-- Alexander Lyon - add
crate to calculate prehashes -->
* vercel/turbo#8174 <!-- Tobias Koppers - use
prehash to avoid rehashing the key in the task cache -->
* vercel/turbo#7674 <!-- Alexander Lyon - [turbo
trace] add ability to filter by value and occurences -->
* vercel/turbo#8287 <!-- Donny/강동윤 - feat:
Update `swc_core` to `v0.92.10` -->
* vercel/turbo#8037 <!-- Alexander Lyon - create
turbo-static for compile time graph analysis -->
* vercel/turbo#8293 <!-- Will Binns-Smith - Sync
Cargo.lock with Next.js -->
* vercel/turbo#8239 <!-- Benjamin Woodruff -
Reduce amount of code generated by ValueDebugFormat -->
* vercel/turbo#8304 <!-- Benjamin Woodruff -
Minor optimizations to the codegen of TaskFnInputFunction -->
* vercel/turbo#8221 <!-- Donny/강동윤 - perf:
Introduce `RcStr` -->


### What?

I tried using `Arc<String>` in
vercel/turbo#7772, but a team member suggested
creating a new type so we can replace underlying implementation easily
in the future.

### Why?

To reduce memory usage.

### How?

Closes PACK-2776
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bgw bgw bgw approved these changes

Assignees
No one assigned
Labels
created-by: turborepo owned-by: turbopack owned-by: turborepo
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@arlyon @bgw