Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(external docs): Fix parsing-csv-logs-with-lua.md example for postgres > 13 #20513

Merged
merged 2 commits into from
May 29, 2024

Conversation

t0k4rt
Copy link
Contributor

@t0k4rt t0k4rt commented May 17, 2024

The provided example does not work for postgres > 13 since there are 3 extra fields in the csv export: backend_type, leader_pid, query_id.
When iterating over csv fields, the script cannot get columns names for these extra fields and fails with error attempt to index a nil value (global 'column_name')

Here is a suggestion to fix the example:

  • iterate over columns name, not csv fields should be preferred imho.
  • add extra column names backend_type, leader_pid, query_id in column_names variable

@t0k4rt t0k4rt requested review from a team as code owners May 17, 2024 08:27
@bits-bot
Copy link

bits-bot commented May 17, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@jszwedko jszwedko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @t0k4rt ! This is appreciated.

@jszwedko jszwedko added the no-changelog Changes in this PR do not need user-facing explanations in the release changelog label May 20, 2024
@jszwedko jszwedko enabled auto-merge May 20, 2024 18:15
Signed-off-by: Jesse Szwedko <jesse.szwedko@datadoghq.com>
@jszwedko jszwedko added this pull request to the merge queue May 28, 2024
Copy link

Regression Detector Results

Run ID: 990c30c4-1b7d-4132-910f-b0f4a663d2f1
Baseline: c8e6d61
Comparison: 5d1ba93
Total CPUs: 7

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI
datadog_agent_remap_blackhole ingress throughput +2.68 [+2.47, +2.88]
syslog_log2metric_splunk_hec_metrics ingress throughput +1.94 [+1.79, +2.09]
http_to_http_acks ingress throughput +1.22 [-0.15, +2.60]
datadog_agent_remap_datadog_logs_acks ingress throughput +1.07 [+0.98, +1.16]
syslog_humio_logs ingress throughput +1.04 [+0.85, +1.22]
splunk_hec_route_s3 ingress throughput +0.77 [+0.30, +1.24]
otlp_http_to_blackhole ingress throughput +0.70 [+0.56, +0.84]
fluent_elasticsearch ingress throughput +0.42 [-0.06, +0.90]
datadog_agent_remap_datadog_logs ingress throughput +0.34 [+0.22, +0.46]
http_to_http_noack ingress throughput +0.22 [+0.13, +0.31]
http_to_http_json ingress throughput +0.03 [-0.04, +0.11]
splunk_hec_to_splunk_hec_logs_acks ingress throughput +0.01 [-0.13, +0.15]
splunk_hec_indexer_ack_blackhole ingress throughput -0.00 [-0.15, +0.14]
syslog_log2metric_tag_cardinality_limit_blackhole ingress throughput -0.03 [-0.14, +0.07]
splunk_hec_to_splunk_hec_logs_noack ingress throughput -0.04 [-0.15, +0.07]
syslog_log2metric_humio_metrics ingress throughput -0.07 [-0.26, +0.12]
enterprise_http_to_http ingress throughput -0.08 [-0.16, +0.01]
http_to_s3 ingress throughput -0.08 [-0.37, +0.20]
datadog_agent_remap_blackhole_acks ingress throughput -0.27 [-0.41, -0.13]
syslog_regex_logs2metric_ddmetrics ingress throughput -0.38 [-0.54, -0.22]
file_to_blackhole egress throughput -0.51 [-2.93, +1.91]
socket_to_socket_blackhole ingress throughput -0.56 [-0.66, -0.46]
otlp_grpc_to_blackhole ingress throughput -0.60 [-0.70, -0.51]
http_text_to_http_json ingress throughput -1.14 [-1.32, -0.96]
syslog_loki ingress throughput -1.59 [-1.67, -1.51]
syslog_splunk_hec_logs ingress throughput -1.67 [-1.80, -1.54]
http_elasticsearch ingress throughput -2.30 [-2.40, -2.20]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

Merged via the queue into vectordotdev:master with commit 006844e May 29, 2024
49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog Changes in this PR do not need user-facing explanations in the release changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants