Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): Bump mlua from 0.9.7 to 0.9.8 #20503

Merged
merged 1 commit into from
May 22, 2024

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github May 16, 2024

Bumps mlua from 0.9.7 to 0.9.8.

Changelog

Sourced from mlua's changelog.

v0.9.8

  • Fixed serializing same table multiple times (#408)
  • Use mlua-sys v0.6 (to support Luau 0.624+)
  • Fixed cross compilation of windows dlls from unix (#394)
Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [mlua](https://github.com/khvzak/mlua) from 0.9.7 to 0.9.8.
- [Release notes](https://github.com/khvzak/mlua/releases)
- [Changelog](https://github.com/mlua-rs/mlua/blob/master/CHANGELOG.md)
- [Commits](mlua-rs/mlua@v0.9.7...v0.9.8)

---
updated-dependencies:
- dependency-name: mlua
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot requested a review from a team as a code owner May 16, 2024 05:07
@dependabot dependabot bot added domain: deps Anything related to Vector's dependencies no-changelog Changes in this PR do not need user-facing explanations in the release changelog labels May 16, 2024
@github-actions github-actions bot added the domain: core Anything related to core crates i.e. vector-core, core-common, etc label May 16, 2024
@bruceg bruceg added this pull request to the merge queue May 16, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 16, 2024
Copy link

Regression Detector Results

Run ID: d55c1bb6-ea6e-4ba8-b6ea-d94f309b6871
Baseline: 911e63d
Comparison: 59e323c
Total CPUs: 7

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

Significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

perf experiment goal Δ mean % Δ mean % CI
syslog_log2metric_tag_cardinality_limit_blackhole ingress throughput +5.07 [+4.91, +5.24]

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI
syslog_log2metric_tag_cardinality_limit_blackhole ingress throughput +5.07 [+4.91, +5.24]
syslog_loki ingress throughput +4.11 [+3.96, +4.26]
syslog_log2metric_splunk_hec_metrics ingress throughput +3.62 [+3.42, +3.82]
datadog_agent_remap_blackhole_acks ingress throughput +3.48 [+3.31, +3.65]
syslog_humio_logs ingress throughput +3.19 [+3.03, +3.35]
http_text_to_http_json ingress throughput +2.64 [+2.43, +2.84]
syslog_splunk_hec_logs ingress throughput +2.45 [+2.31, +2.60]
syslog_log2metric_humio_metrics ingress throughput +0.88 [+0.70, +1.06]
datadog_agent_remap_datadog_logs_acks ingress throughput +0.62 [+0.48, +0.75]
syslog_regex_logs2metric_ddmetrics ingress throughput +0.59 [+0.32, +0.86]
socket_to_socket_blackhole ingress throughput +0.58 [+0.46, +0.70]
otlp_http_to_blackhole ingress throughput +0.51 [+0.36, +0.66]
datadog_agent_remap_blackhole ingress throughput +0.48 [+0.34, +0.62]
fluent_elasticsearch ingress throughput +0.31 [-0.19, +0.80]
http_to_s3 ingress throughput +0.27 [-0.01, +0.56]
otlp_grpc_to_blackhole ingress throughput +0.12 [+0.02, +0.22]
http_to_http_noack ingress throughput +0.05 [-0.06, +0.16]
http_to_http_json ingress throughput +0.04 [-0.04, +0.12]
splunk_hec_indexer_ack_blackhole ingress throughput +0.00 [-0.14, +0.15]
splunk_hec_to_splunk_hec_logs_acks ingress throughput -0.00 [-0.14, +0.14]
splunk_hec_to_splunk_hec_logs_noack ingress throughput -0.04 [-0.15, +0.08]
enterprise_http_to_http ingress throughput -0.11 [-0.18, -0.03]
http_elasticsearch ingress throughput -0.24 [-0.32, -0.15]
http_to_http_acks ingress throughput -0.30 [-1.68, +1.07]
file_to_blackhole egress throughput -0.35 [-2.89, +2.19]
datadog_agent_remap_datadog_logs ingress throughput -0.53 [-0.65, -0.41]
splunk_hec_route_s3 ingress throughput -0.58 [-1.08, -0.09]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

@jszwedko jszwedko added this pull request to the merge queue May 20, 2024
@jszwedko jszwedko removed this pull request from the merge queue due to the queue being cleared May 20, 2024
@jszwedko jszwedko added this pull request to the merge queue May 21, 2024
Copy link

Regression Detector Results

Run ID: b5129525-21d9-4a75-aeb5-a53cc61c0eb0
Baseline: d1c2aec
Comparison: 7c745d2
Total CPUs: 7

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI
syslog_log2metric_tag_cardinality_limit_blackhole ingress throughput +2.39 [+2.26, +2.51]
socket_to_socket_blackhole ingress throughput +2.00 [+1.92, +2.08]
syslog_humio_logs ingress throughput +1.80 [+1.65, +1.96]
syslog_loki ingress throughput +1.66 [+1.60, +1.72]
http_text_to_http_json ingress throughput +1.64 [+1.49, +1.79]
file_to_blackhole egress throughput +1.36 [-1.10, +3.82]
syslog_log2metric_humio_metrics ingress throughput +1.28 [+1.16, +1.40]
otlp_grpc_to_blackhole ingress throughput +1.19 [+1.10, +1.28]
fluent_elasticsearch ingress throughput +0.84 [+0.36, +1.32]
syslog_splunk_hec_logs ingress throughput +0.66 [+0.61, +0.71]
splunk_hec_route_s3 ingress throughput +0.63 [+0.18, +1.08]
http_to_s3 ingress throughput +0.38 [+0.10, +0.66]
datadog_agent_remap_blackhole_acks ingress throughput +0.38 [+0.29, +0.46]
datadog_agent_remap_blackhole ingress throughput +0.27 [+0.18, +0.36]
otlp_http_to_blackhole ingress throughput +0.27 [+0.16, +0.38]
datadog_agent_remap_datadog_logs_acks ingress throughput +0.19 [+0.10, +0.27]
http_to_http_noack ingress throughput +0.16 [+0.07, +0.25]
http_to_http_json ingress throughput +0.03 [-0.05, +0.11]
datadog_agent_remap_datadog_logs ingress throughput +0.02 [-0.08, +0.13]
splunk_hec_to_splunk_hec_logs_acks ingress throughput -0.00 [-0.14, +0.14]
splunk_hec_indexer_ack_blackhole ingress throughput -0.01 [-0.15, +0.14]
splunk_hec_to_splunk_hec_logs_noack ingress throughput -0.03 [-0.15, +0.08]
http_elasticsearch ingress throughput -0.07 [-0.14, -0.00]
enterprise_http_to_http ingress throughput -0.07 [-0.15, +0.00]
syslog_log2metric_splunk_hec_metrics ingress throughput -0.96 [-1.10, -0.81]
syslog_regex_logs2metric_ddmetrics ingress throughput -1.66 [-1.77, -1.55]
http_to_http_acks ingress throughput -2.08 [-3.42, -0.73]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

Merged via the queue into master with commit 7c745d2 May 22, 2024
57 checks passed
@jszwedko jszwedko deleted the dependabot/cargo/mlua-0.9.8 branch May 22, 2024 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain: core Anything related to core crates i.e. vector-core, core-common, etc domain: deps Anything related to Vector's dependencies no-changelog Changes in this PR do not need user-facing explanations in the release changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants