Update FindPath in 2D version #10
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we calculate a path to a neighbor, we either need to update that neighbor's cost, or add it to the queue. The old code seems to try and update the cost of the current node instead of the neighbor, which does not seem right? It also very rarely causes a path to not be found, even though it exists and the end node was visited as a neighbor but never added to the queue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This might also be an issue in 3D, but I haven't tested it. When we calculate a path to a neighbor, we either need to update that neighbor's cost, or add it to the queue. The old code seems to try and update the cost of the current node instead of the neighbor, which does not seem right? It also very rarely causes a path to not be found, even though it exists and the end node was visited as a neighbor but never added to the queue.