Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update client-side-cacing.md #72

Merged
merged 2 commits into from
May 3, 2024
Merged

Update client-side-cacing.md #72

merged 2 commits into from
May 3, 2024

Conversation

Virusuki
Copy link
Contributor

@Virusuki Virusuki commented May 1, 2024

If i don't look closely the explanation in client-side-caching, I think the Database term is ambiguous.
Because it can be thought of as the entire database, it would be better to specify it as a valkey.

Also, change channel name the redis:invalidate to valkey:invalidate.

Signed-off-by: NAM UK KIM <namuk2004@naver.com>
Copy link
Contributor

@zuiderkwast zuiderkwast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be a breaking change to change client-side caching like that. (Obviously you didn't test it. 🙂) There's a PR about it, but it's not yet decided how we can do it to avoid breaking clients.

Changing the word database in the text is OK, but the name is Valkey, not valkey.

Signed-off-by: NAM UK KIM <namuk2004@naver.com>
@Virusuki
Copy link
Contributor Author

Virusuki commented May 3, 2024

It would be a breaking change to change client-side caching like that. (Obviously you didn't test it. 🙂) There's a PR about it, but it's not yet decided how we can do it to avoid breaking clients.

Changing the word database in the text is OK, but the name is Valkey, not valkey.

I know there are side effects to changing redis:invalidate.
I'll have to think carefully about it PR #410.

Additionally, I changed it to "database" -> "Valkey".

Copy link
Contributor

@zuiderkwast zuiderkwast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! It like to merge this change first.

@zuiderkwast zuiderkwast merged commit 6842a46 into valkey-io:main May 3, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants