Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Catch post request variable evaluation errors #2324

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rbideau
Copy link
Contributor

@rbideau rbideau commented May 16, 2024

fix #2005

Description

  • display post request variable evaluation errors in a toast, each individual variable error on a new line
  • display the response body (was previously replaced by the an error "Error invoking remote method 'send-http-request': ..."

image

Contribution Checklist:

  • The pull request only addresses one issue or adds one feature.
  • The pull request does not introduce any breaking changes
  • I have added screenshots or gifs to help explain the change if applicable.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request.

Note: Keeping the PR small and focused helps make it easier to review and merge. If you have multiple changes you want to make, please consider submitting them as separate pull requests.

Publishing to New Package Managers

Please see here for more information.

@helloanoop
Copy link
Contributor

Nice @rbideau !

@lohxt1 Lets target ti have this merged for next week's release.

fix usebruno#2005

- display post request variable evaluation errors in a toast, each individual variable error on a new line
- display the response body (was previously replaced by the an error "Error invoking remote method 'send-http-request': ..."
@rbideau rbideau force-pushed the feature/toast-for-post-request-var-errors branch from b9dbbab to 35e75d2 Compare May 22, 2024 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants