Re-aligning the main ribbon in the header to the centre #3520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ribbon is in the extreme right which can be aligned to the centre by simply changing the value of right attribute
ritwik12
added
the
discussion
|
@shiftkey if there are no modifications / addition requires please merge the PR |
|
@shiftkey Please merge if looks good to you |
|
👋 I'm a robot checking the state of this pull request to save the human reviewers time. I don't see any changes under As you make changes to this pull request, I'll re-run these checks. |
shiftkey
requested changes
Aug 27, 2023
| @@ -704,7 +704,7 @@ form { | |||
| text-align: center; | |||
| padding: .5em 1em; | |||
| margin: 0 auto 0; | |||
| right: 2em; | |||
| right: 15em; | |||
There was a problem hiding this comment.
This breaks viewing the header when the viewport is narrow, because it's a hard-coded value:
I'd recommend looking for a solution that works better at different widths (flexbox?), and considering how the header looks when testing in responsive mode in your local browser dev tools:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ribbon is in the extreme right which can be aligned to the centre by simply changing the value of right attribute
Before:
After: