Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement the X Drag and Drop (XDnD) extension to accept dragging from other windows #16089

Merged
merged 29 commits into from
May 18, 2024
Merged

feat: implement the X Drag and Drop (XDnD) extension to accept dragging from other windows #16089

merged 29 commits into from
May 18, 2024

Conversation

ramezgerges
Copy link
Contributor

@ramezgerges ramezgerges commented Apr 2, 2024 •
edited

GitHub Issue (If applicable): closes #13982, partially fixes https://github.com/unoplatform/uno-private/issues/356

PR Type

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior?

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

You can validate the behaviour with the DragDrop_Basics and DragDrop_ListView samples.

Internal Issue (If applicable):

@ramezgerges ramezgerges marked this pull request as draft April 2, 2024 12:06
@github-actions github-actions bot added area/skia ✏️ Categorizes an issue or PR as relevant to Skia area/automation Categorizes an issue or PR as relevant to project automation labels Apr 2, 2024
@ramezgerges
Copy link
Contributor Author

This one will conflict heavily with #15799, so let's merge that one first

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-16089/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-16089/index.html

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-16089/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-16089/index.html

@ramezgerges
Copy link
Contributor Author

@dr1rrb I've noticed a lot of duplication and/or unused path-through methods between CoreDragDropManager and DragDropManager. Would it be a good idea to combine both into a single class?

@ramezgerges ramezgerges requested a review from dr1rrb April 2, 2024 16:48
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-16089/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-16089/index.html

@github-actions github-actions bot added platform/wasm 🌐 Categorizes an issue or PR as relevant to the WebAssembly platform platform/macos 🍏 Categorizes an issue or PR as relevant to the macOS platform labels May 6, 2024
@ramezgerges ramezgerges marked this pull request as ready for review May 6, 2024 19:38
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-16089/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-16089/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-16089/index.html

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-16089/index.html

1 similar comment
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-16089/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-16089/index.html

1 similar comment
@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-16089/index.html

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-16089/index.html

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-16089/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-16089/index.html

@ramezgerges
Copy link
Contributor Author

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-16089/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-16089/index.html

@ramezgerges
Copy link
Contributor Author

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-16089/index.html

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-16089/index.html

@Youssef1313
Copy link
Member

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-16089/index.html

@github-actions github-actions bot removed the area/automation Categorizes an issue or PR as relevant to project automation label May 18, 2024
@Youssef1313 Youssef1313 marked this pull request as draft May 18, 2024 09:20
auto-merge was automatically disabled May 18, 2024 09:20

Pull request was converted to draft

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-16089/index.html

@github-actions github-actions bot added the area/automation Categorizes an issue or PR as relevant to project automation label May 18, 2024
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-16089/index.html

@ramezgerges ramezgerges marked this pull request as ready for review May 18, 2024 13:59
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-16089/index.html

@ramezgerges ramezgerges merged commit c63ae32 into unoplatform:master May 18, 2024
103 checks passed
@ramezgerges ramezgerges deleted the xdnd branch May 18, 2024 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeromelaban jeromelaban jeromelaban left review comments

@MartinZikmund MartinZikmund MartinZikmund approved these changes

@dr1rrb dr1rrb Awaiting requested review from dr1rrb

Assignees
No one assigned
Labels
area/automation Categorizes an issue or PR as relevant to project automation area/skia ✏️ Categorizes an issue or PR as relevant to Skia platform/macos 🍏 Categorizes an issue or PR as relevant to the macOS platform platform/wasm 🌐 Categorizes an issue or PR as relevant to the WebAssembly platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add multi-XamlRoot support for drag and drop
5 participants
@ramezgerges @unodevops @Youssef1313 @MartinZikmund @jeromelaban