This repository has been archived by the owner on Apr 11, 2023. It is now read-only.
Added visual indicator to the entire window, when active, vim-vixen should interpret keystrokes (as opposed to when a textbox has focus and recieves keyboard input) #744 #782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hould interpret keystrokes (as opposed to when a textbox has focus and recieves keyboard input)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR may require some styling work by the vim-vixen maintainers, but it should create a better visual indicator of whether vim-vixen is 'active' or if keyboard events will be directed to some other element on the screen (such as a textbox etc).
Sorry it's not well tested, I'm not familiar with testing frontend components and don't have the time to learn, I would have held off longer but additional interest into the issue ( #744 ) has pushed me into adding a PR.