Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(type-utils): add tests for functions in typeFlagUtils #8956

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

y-hsgw
Copy link
Contributor

@y-hsgw y-hsgw commented Apr 20, 2024

PR Checklist

Overview

add Testcase in typeFlagUtils Functions.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @y-hsgw!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlify bot commented Apr 20, 2024

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 4d6d8ce
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/665c0bd3e3576500087f7c9e
😎 Deploy Preview https://deploy-preview-8956--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 99 (🟢 up 1 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

expected: boolean,
): void {
const type = getType(code);
const result = isTypeFlagSet(type, flagsToCheck);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the third argument 'isReceiver' in the function 'isTypeFlagSet' necessary?
Considering its usage in the callers of 'isTypeFlagSet', it doesn't seem to be utilized. Hence, I was wondering if it's safe to remove it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it's never used in our code, you can mark it as deprecated and we can remove it later.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Added in 4d6d8ce .

Copy link
Contributor

@rubiesonthesky rubiesonthesky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small typo fixes :)

packages/type-utils/tests/typeFlagUtils.test.ts Outdated Show resolved Hide resolved
packages/type-utils/tests/typeFlagUtils.test.ts Outdated Show resolved Hide resolved
@bradzacher bradzacher added the tests anything to do with testing label May 28, 2024
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🙌

@JoshuaKGoldberg JoshuaKGoldberg added the 1 approval One team member has approved this PR; a second should be enough to merge it label Jun 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 approval One team member has approved this PR; a second should be enough to merge it tests anything to do with testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants