Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/improve table cell recoil value #5293

Closed
wants to merge 7 commits into from
Closed

Feat/improve table cell recoil value #5293

wants to merge 7 commits into from

Conversation

lucasbordeau
Copy link
Contributor

Test

@github-actions GitHub Actions
Copy link

github-actions bot commented May 4, 2024 •
edited

TODOs/FIXMEs:

  • // Todo: Fix this type: packages/twenty-front/src/modules/object-record/record-field/meta-types/display/components/RelationFieldDisplay.tsx

Generated by 🚫 dangerJS against 1e5152d

@lucasbordeau lucasbordeau marked this pull request as draft May 4, 2024 17:06
github-advanced-security[bot]
github-advanced-security bot found potential problems May 6, 2024
View reviewed changes
playwright.config.ts

extraHTTPHeaders: {
Authorization:
'Bearer eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJzdWIiOiIyMDIwMjAyMC05ZTNiLTQ2ZDQtYTU1Ni04OGI5ZGRjMmIwMzQiLCJ3b3Jrc3BhY2VJZCI6IjIwMjAyMDIwLTFjMjUtNGQwMi1iZjI1LTZhZWNjZjdlYTQxOSIsImlhdCI6MTcxNDU1OTA2NSwiZXhwIjoxNzIyMzM1MDY1fQ.3OkFv0F9Jp8aSb6esRRzG6s1eb8BRx6ND4pOPpkfOXc',

Check failure

Code scanning / CodeQL

Hard-coded credentials Critical

The hard-coded value "Bearer eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJzdWIiOiIyMDIwMjAyMC05ZTNiLTQ2ZDQtYTU1Ni04OGI5ZGRjMmIwMzQiLCJ3b3Jrc3BhY2VJZCI6IjIwMjAyMDIwLTFjMjUtNGQwMi1iZjI1LTZhZWNjZjdlYTQxOSIsImlhdCI6MTcxNDU1OTA2NSwiZXhwIjoxNzIyMzM1MDY1fQ.3OkFv0F9Jp8aSb6esRRzG6s1eb8BRx6ND4pOPpkfOXc" is used as
authorization header
.
@charlesBochet
Copy link
Member

Per discussion with you, let's close this PR.
Take out:

  • we can get a x2 factor on Cell Performance by implementing ContextSelector instead of Recoil access and leverage native JS events for soft focus. Let's keep that in mind

In next PRs:

  • add a CI to implement storybook performance testing
  • working on FieldDisplay to leverage native css class

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lucasbordeau @charlesBochet