Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: record board column border spans the available screen height #5290

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

orinamio
Copy link
Contributor

@orinamio orinamio commented May 3, 2024

Resolves #5273

@FelixMalfait
Copy link
Member

I'm going to be annoying but this introduces a small unnecessary vertical scroll, could you try fix that?

Screenshot 2024-05-04 at 15 59 46

Thanks a lot!

@orinamio
Copy link
Contributor Author

orinamio commented May 6, 2024

@FelixMalfait I agree the scroll is unnecessary and ugly.

A solution for the vertical scroll is to hide the scroll permanently using display: none; or something similar. However, I don't think it's the best approach. When more row items are in a column, the scroll should be visible. This is good for the user experience.

I tried to use @container CSS. But this breaks the Drag and Drop component. I couldn't find out why it was happening.

  container-type: size;

  .os-scrollbar-vertical {
    display: none;
  }

  @container (height > [SIZE]) {
    .os-scrollbar-vertical {
      display: unset;
    }
  }

The container rule breaks the dnd:

dnd.mov

Furthermore, using JavaScript to fix this doesn't seem appropriate.

Do you have any suggestions? cc: @Weiko

@orinamio
Copy link
Contributor Author

orinamio commented May 6, 2024

This is the behaviour when the scrollbar is removed:

without_vertical_scrollbar.mov

If this is acceptable, I'll go ahead and add this fix. Otherwise, I ask that someone else looks into it.

@FelixMalfait
Copy link
Member

Thanks @orinamio! We try to set the design/quality bar high so hiding the scrollbar isn't good enough, we should try to find the right solution. We'll wait for someone else to look into this. Thanks a lot for your help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Record board columns design fix (full height borders)
2 participants