New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: replace iframe with chrome sidepanel #5197
base: main
Are you sure you want to change the base?
Conversation
openOptionsPage(); | ||
} | ||
}); | ||
// chrome.runtime.onInstalled.addListener((details) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Commenting this for now, will replace it with a call to a dedicated page for chrome extension of twenty documentation
<MainButton | ||
title="Sign up" | ||
variant="secondary" | ||
onClick={() => window.open(`${import.meta.env.VITE_FRONT_BASE_URL}`, '_blank')} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed the signup link
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't go to the page in the side panel when it's already open, see linked video
Enregistrement.de.l.ecran.2024-04-30.a.16.19.27.mov
- We should disable selecting the text of the button : user-select: none;
); | ||
personButtonSpan.textContent = 'View in Twenty'; | ||
personButtonDiv.onClickHandler(() => { | ||
chrome.runtime.sendMessage({ action: 'openSidepanel' }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should change side panel url if already open ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct! I fixed it :)
@@ -4,24 +4,31 @@ import styled from '@emotion/styled'; | |||
import { Loader } from '@/ui/display/loader/components/Loader'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we rename Options into a more self-explanatory naming ? Options seems very vague, SidePanel or something like that would be more appropriate.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done 👍
…into chrome-side-panel
fixes - #5201
Screen.Recording.2024-04-27.at.6.55.08.PM.mov