Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: gmail attachments #5081
feat: gmail attachments #5081
Changes from all commits
430d3f7
0900424
db95d4a
3f4265f
93e6744
78a7fdd
0b6d121
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the change, but after discussion with the team, we now want to create a new composite FieldMetadataType
File
(you can take example onFieldMetadataType.Link
inpackages/twenty-server/src/engine/metadata-modules/field-metadata/composite-types/link.composite-type.ts
) instead of creating a new storage driver type, sincegmail
is not really a storage driver type.This composite field should have the following properties:
fullPath
which will be computed insidequery-result-getters.factory
.The table
Attachment
will only have one column of typeFile
(in addition to the id, createdAt, updatedAt ... and the relations).In
packages/twenty-server/src/engine/core-modules/file/controllers/file.controller.ts
we want to create a new endpoint@Get(gmail/:filename)
which will call users.messages.attachments.get to get the fileStream.@charlesBochet can help you if you have any questions regarding this change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense 馃憤 Ive actually already added one composite field :D #4492 This time it should be hopefully a bit easier though as I wont aim to add it as a field assignable to an object + read/write table, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! It will actually be very similar, with an additional tweak on the getters logic! I can assist you if you have any question :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feel free to ping on Discord direclty if you need real time inputs!