Bugfixes May 2024 (Part 1) #474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es utils Co-authored-by: Jean-Philippe Bossuat <jean-philippe@tuneinsight.com>
Pro7ech
reviewed
May 17, 2024
qantik
force-pushed
the
bugfixes-may-2024-part1
branch
from
0e3213f
to
1952973
Compare
This was
linked to
issues
Jun 7, 2024
romainbou
approved these changes
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR bundles various bug fixes:
Bug [utils]: some
rlweandmhetests always pass due to a bug inutils.MaxSliceandutils.MinSlice#457 (b326b02): Fix correctness errors inutils.MaxSlice/MinSlice. Prevent panic inutils.EqualSliceBug [rlwe]:
rlwe.Parameters.ReadFromfails (PR #456) #459 (93154bd): Fix regression inrlwe.Parametersmarshaller."How is EncodingDomain set?" #466 (34a6325): Update reals tutorial explanation.
Bug[rlwe]: bad
rlwe.Parametersinitialization with no error #458 / Bug[rlwe]:Parameters.UnmarshalJSON#471 (51451c4): Do not mix log/non-log primes inrlwe.ParametersLiteralinitialisation.Bug[rlwe]:
rlwe.Scaleserialization #465 (454efab): Use decimal encoding to preserverlwe.Scaleto preserve binary size.Bump minimum Go version to 1.21 with the use of
slices(25e88da): New bug reports policy.