Fix missing logs when client includes their own @opentelemetry/api #1106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 84127b4 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
ericallam
force-pushed
the
v3/opentelemetry-api-mismatch-fix
branch
from
2ec1550
to
84127b4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a user has their own
@opentelemetry/apipackage, which is a different version from ours, then task logs will fail to be sent to the platform because opentelemetry will fail to register our tracing API with the following error message:The solution was to make sure the user's
@opentelemetry/apiwas not imported by the worker prior to our trace API registration. Removing the@opentelemetry/resourcesimport fromworker-setup.tswas enough to solve this problem because it imports@opentelemetry/api, and the top-level@opentelemetry/apiinside node_modules is the users, not the one inside@trigger.dev/core.