Add historycmdcount* configs to limit cmdHistory size #4820
Conversation
Add config `historycmdcountalert` and `historycmdcountlimit` to limit `state.cmdHistory` size. If `state.cmdHistory` size is larger then the historycmdcountalert when tridactyl start, tridactyl will reduce its size to the historycmdcountlimit. The cmdHistory size check has a 15 seconds delay, so the start up will not be to slow.
Without config this will be a breaking change.
|
Im not sure if there are issues about command history size. By the way, I see #4763 so I resolve it in this branch, too. |
src/lib/config.ts
Outdated
| /** | ||
| * Reduce the size (line count) of ex command history if the size is larger than the historycmdcountalert when tridactyl started. The size will be reduce to the historycmdcountlimit. | ||
| */ | ||
| historycmdcountlimit = 512 |
There was a problem hiding this comment.
I'd rather have one setting rather than two. Maybe remove 1/3 when it hits the limit.
512 seems pretty small, I'd set it to something much bigger like 100k. I think most of the time people are searching through it rather than just scrolling up
| const alert = await config.getAsync('historycmdcountalert') | ||
| const limit = await config.getAsync('historycmdcountlimit') | ||
| const cmdHistory = state.cmdHistory | ||
| if (cmdHistory.length > alert) { |
There was a problem hiding this comment.
We should support -1 for unlimited
| @@ -160,7 +160,8 @@ export function getCommandlineFns(cmdline_state: { | |||
| // Save non-secret commandlines to the history. | |||
| if ( | |||
| !browser.extension.inIncognitoContext && | |||
| !(func === "winopen" && args[0] === "-private") | |||
| !(func === "winopen" && args[0] === "-private") && | |||
There was a problem hiding this comment.
Maybe we should support zero to totally disable saving of history?
There was a problem hiding this comment.
I does not like the idea that do State.getAsync('historycmdcountlimit') everytime before save ex command,
but we already do this while saving history.
I can not remember exactly. My tridactyl is not very fast since I have so many tabs. I believe someone (maybe me?) asked about history command size issue but I can not find it. |
So we do not need two config.
Add config
historycmdcountalertandhistorycmdcountlimitto limitstate.cmdHistorysize.If
state.cmdHistorysize is larger then the historycmdcountalert when tridactyl start, tridactyl will reduce its size to the historycmdcountlimit.The cmdHistory size check has a 15 seconds delay,
so the start up will not be to slow.
Feel free to change to a better config name or move the code snippet.