Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: add keyup/down bind support #4727

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

Conversation

bovine3dom
Copy link
Member

@bovine3dom bovine3dom commented Jun 11, 2023

I hate rebasing

Supercedes #1645


Observations:

  • implicit keyups aren't being ignored, j leads to scrolling twice
  • hint mode broken
  • user binds broken (e.g. :bind ,q fillcmdline test)
  • sometimes follows links in hint modes(!?)
  • adding a user bind of <D-j> binds to <<UD?-<>D<U?-D>-<U?-->j<U?-j>> (i.e. the key sequence literally typed out)
  • hardcoded bind of <D-e> doesn't work

@bovine3dom
Copy link
Member Author

I think I need to look back through #4440 and make sure that everywhere that changed things, keyup/keydown/repeat/optional key events work.

I also need to look back at #1645 and try to remember what it was I had decided about repeat keys - there is a .repeat property on keyboard events, maybe we need to update minimalKeyboardEvent to include that information?

I think I just deleted some logic about repeat that I probably shouldn't have deleted...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant