Add DownloadPost event to autocmds #4660
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bovine3dom
commented
Apr 8, 2023
| @@ -2361,7 +2361,7 @@ if (fullscreenApiIsPrefixed) { | |||
|
|
|||
| /** @hidden */ | |||
| //#content | |||
| export async function loadaucmds(cmdType: "DocStart" | "DocLoad" | "DocEnd" | "TabEnter" | "TabLeft" | "FullscreenEnter" | "FullscreenLeft" | "FullscreenChange" | "UriChange" | "HistoryState") { | |||
| export async function loadaucmds(cmdType: "DocStart" | "DocLoad" | "DocEnd" | "TabEnter" | "TabLeft" | "FullscreenEnter" | "FullscreenLeft" | "FullscreenChange" | "UriChange" | "HistoryState" | "DownloadPost") { | |||
| const aucmds = await config.getAsync("autocmds", cmdType) | |||
| if (!aucmds) return | |||
| const ausites = Object.keys(aucmds) | |||
There was a problem hiding this comment.
Hey @antonva just casually looking at your 4 year-old PR
Your DownloadPost events are triggered based on the page currently being viewed
const aukeyarr = ausites.filter(e => window.document.location.href.search(e) >= 0)
Was that intentional? It seems a little weird to me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supercedes #1495
Edit: fixes #807
#1495 was going to look at #810 but I have removed those bits for now to try to get this merged within the next four years