Added timeouts for onProgess #444
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@transitive-bullshit can you please take a look on it? |
|
Yes, I think this feature would be helpful when the response text is long so that it doesn't get aborted during streaming. @transitive-bullshit |
|
hey sorry @Vadko, this PR is more complicated and I think it could have some unintended consequences so I've been putting off reviewing it. |
|
@transitive-bullshit I've updated branch, it is ready to review |
|
@transitive-bullshit any chance you can look into it?🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #410
tested both official&unofficial api