-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(milvus): add Milvus instrumentation #1068
Conversation
Jose Cespedes seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Also mentioning #244 the issue here as well |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much @Josecespedesant! Looks like there's an error when trying to install the package, can you take a look?
Hello @nirga, I think it was because I didn't add the pymilvus dependency into |
@Josecespedesant looks like there's a conflict during installation: https://github.com/traceloop/openllmetry/actions/runs/9147471985/job/25149747974 |
Will take a look at it! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good. Left a small comment, and we need to make the test pass
"span_name": "milvus.insert" | ||
}, | ||
{ | ||
"package": pymilvus, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this needs to be a string otherwise this may fail
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi! From what I saw in the chromadb instrumentation the package is added directly as this, I don't know if for this case it's different but it seems to work as this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right! I was only looking at Pinecone
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much @Josecespedesant, great work!
Thank you very much! Looking forward to work on any other issue that arises 🙌 |
Fixes #244
Testing instrumentation in Traceloop:
feat(instrumentation): ...
orfix(instrumentation): ...
.