Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(milvus): add Milvus instrumentation #1068

Merged
merged 13 commits into from
May 20, 2024
Merged

Conversation

Josecespedesant
Copy link
Contributor

@Josecespedesant Josecespedesant commented May 19, 2024

Fixes #244

Testing instrumentation in Traceloop:

image

  • I have added tests that cover my changes. (Same as chromadb package, some test cases can still be added)
  • If adding a new instrumentation or changing an existing one, I've added screenshots from some observability platform showing the change.
  • PR name follows conventional commits format: feat(instrumentation): ... or fix(instrumentation): ....
  • (If applicable) I have updated the documentation accordingly.

@CLAassistant
Copy link

CLAassistant commented May 19, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ Josecespedesant
❌ Jose Cespedes


Jose Cespedes seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@Josecespedesant Josecespedesant marked this pull request as ready for review May 19, 2024 05:43
@Josecespedesant
Copy link
Contributor Author

Also mentioning #244 the issue here as well

@nirga nirga self-assigned this May 19, 2024
@nirga nirga changed the title feat(milvus) Adding Milvus instrumentation to OpenLLMetry feat(milvus): add Milvus instrumentation to OpenLLMetry May 19, 2024
@nirga nirga changed the title feat(milvus): add Milvus instrumentation to OpenLLMetry feat(milvus): add Milvus instrumentation May 19, 2024
Copy link
Member

@nirga nirga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much @Josecespedesant! Looks like there's an error when trying to install the package, can you take a look?

@Josecespedesant
Copy link
Contributor Author

Hello @nirga, I think it was because I didn't add the pymilvus dependency into tool.poetry.dependencies and only to the test section. Just added it, built it via poetry and installed it using pip and now it allows me to import the MilvusInstrumentor, could you please take a look at it again?

@nirga
Copy link
Member

nirga commented May 19, 2024

@Josecespedesant looks like there's a conflict during installation:

https://github.com/traceloop/openllmetry/actions/runs/9147471985/job/25149747974

@Josecespedesant
Copy link
Contributor Author

Will take a look at it!

Copy link
Member

@nirga nirga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good. Left a small comment, and we need to make the test pass

"span_name": "milvus.insert"
},
{
"package": pymilvus,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this needs to be a string otherwise this may fail

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! From what I saw in the chromadb instrumentation the package is added directly as this, I don't know if for this case it's different but it seems to work as this?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right! I was only looking at Pinecone

Copy link
Member

@nirga nirga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much @Josecespedesant, great work!

@nirga nirga merged commit f6ea8ce into traceloop:main May 20, 2024
7 of 8 checks passed
@Josecespedesant
Copy link
Contributor Author

Thank you very much! Looking forward to work on any other issue that arises 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🚀 Feature: Milvus Instrumentation
3 participants