Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added min onnx import #1778

Merged
merged 2 commits into from
May 22, 2024
Merged

Conversation

JachymPutta
Copy link
Contributor

Pull Request Template

Checklist

  • Confirmed that run-checks all script has been executed. (doc errors, many jit tests failing)
  • Made sure the book is up to date with changes in this PR.

Related Issues/PRs

Provide links to relevant issues and dependent PRs.

Changes

Adding the min operator to onnx-import

Testing

Done manually with:
cargo test min

Copy link
Member

@nathanielsimard nathanielsimard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but tagging @laggui for review

Copy link
Member

@laggui laggui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't notice a PR was opened for Min too!

LGTM 🙂 Just need to fix the conflicts

@laggui
Copy link
Member

laggui commented May 22, 2024

Thank you 🙏

Will merge when CI is done.

@JachymPutta
Copy link
Contributor Author

Great! Thank you:)

Copy link

codecov bot commented May 22, 2024

Codecov Report

Attention: Patch coverage is 96.87500% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 86.42%. Comparing base (550086a) to head (3a36207).

Files Patch % Lines
crates/burn-import/src/burn/node/binary.rs 90.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1778   +/-   ##
=======================================
  Coverage   86.41%   86.42%           
=======================================
  Files         737      737           
  Lines       86099    86131   +32     
=======================================
+ Hits        74406    74437   +31     
- Misses      11693    11694    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@laggui laggui merged commit 0918cf0 into tracel-ai:main May 22, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants