Contributor Book: Onnx to Burn Conversion #1771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathanielsimard
approved these changes
May 21, 2024
There was a problem hiding this comment.
Wow, that is a very well-written and detailed documentation on how to add new operations to ONNX. Tagging @laggui to make sure I didn't miss anything while reviewing 😅
laggui
reviewed
May 21, 2024
laggui
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Checklist
n/a
run-checks allscript has been executed.Changes
The previous instructions in onnx-to-burn-conversion.md for Implement Missing Operators was basically "implement it", which threw me for a loop when I realized too late that this was a tad more involved than originally anticipated. I think the contributor book could use some more documentation/lip service around this topic.
Please let me know if something doesn't look right/edits are in order/I got something completely wrong. I'll add links later after PR #1753 is merged.