Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing initialization declaration #35

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixing initialization declaration #35

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Aug 4, 2014

Changed self to super, otherwise, will call init constructor from
subclasses and can stay in infinite loop.

Ex:
If I override init method in my subclass:

@implementation SignUpViewController

- (id)init {
    self = [super initWithUrl:[NSURL URLWithString:kSignUpUrl]];
    return self;
}

It will call:

- (id)initWithUrl:(NSURL*)url {
    self = [self init];
    if(self)
    ...
}

That will call SignUpViewController.init

Changed self to super, otherwise, will call init constructor from
subclasses and can stay in infinite loop
@darko55555
Copy link

This is correct, nice one!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant