Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(std): add exec method to CommandManager #7090

Merged
merged 2 commits into from
May 21, 2024

Conversation

doouding
Copy link
Member

@doouding doouding commented May 17, 2024

Add exec to allow executing a single command without calling chain. Usage is shown below.

const result = this.std.command.exec('getBlockIndex');

console.log(result.blockIndex);

Copy link

vercel bot commented May 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blocksuite ❌ Failed (Inspect) May 21, 2024 7:59am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
blocksuite-docs ⬜️ Ignored (Inspect) Visit Preview May 21, 2024 7:59am

Copy link

graphite-app bot commented May 17, 2024

Your org has enabled the Graphite merge queue for merging into master

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@doouding doouding requested a review from Saul-Mirone May 17, 2024 12:13
Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @doouding and the rest of your teammates on Graphite Graphite

@doouding doouding marked this pull request as ready for review May 17, 2024 12:14
@doouding doouding requested a review from doodlewind as a code owner May 17, 2024 12:14
@doouding doouding changed the title feat(std): add execCommand to CommandManager feat(std): add exec method to CommandManager May 17, 2024
Copy link

graphite-app bot commented May 17, 2024

Merge activity

  • May 17, 11:42 AM EDT: doouding added this pull request to the Graphite merge queue.
  • May 17, 11:50 AM EDT: The Graphite merge queue couldn't merge this PR because it was not satisfying all requirements (PR has had changes requested).

doouding added a commit that referenced this pull request May 17, 2024
Add `exec` to allow executing a single command without calling `chain`.  Usage is shown below.

```TypeScript
const result = this.std.command.exec('getBlockIndex');

console.log(result.blockIndex);
```
@doouding doouding force-pushed the 05-17-feat_std_add_execcommand_to_commandmanager branch from a666377 to ef56926 Compare May 17, 2024 15:43
Copy link
Collaborator

@Saul-Mirone Saul-Mirone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add som unit tests?

@doouding
Copy link
Member Author

I've added some tests.

@doouding doouding requested a review from Saul-Mirone May 20, 2024 01:54
doouding added a commit that referenced this pull request May 21, 2024
Add `exec` to allow executing a single command without calling `chain`.  Usage is shown below.

```TypeScript
const result = this.std.command.exec('getBlockIndex');

console.log(result.blockIndex);
```
@doouding doouding force-pushed the 05-17-feat_std_add_execcommand_to_commandmanager branch from d99f571 to 176df40 Compare May 21, 2024 07:34
doouding and others added 2 commits May 21, 2024 15:35
Add `exec` to allow executing a single command without calling `chain`.  Usage is shown below.

```TypeScript
const result = this.std.command.exec('getBlockIndex');

console.log(result.blockIndex);
```
@doouding doouding force-pushed the 05-17-feat_std_add_execcommand_to_commandmanager branch from 176df40 to ba48630 Compare May 21, 2024 07:35
@Saul-Mirone Saul-Mirone enabled auto-merge (squash) May 21, 2024 07:41
@Saul-Mirone Saul-Mirone merged commit d28673e into master May 21, 2024
17 of 19 checks passed
@Saul-Mirone Saul-Mirone deleted the 05-17-feat_std_add_execcommand_to_commandmanager branch May 21, 2024 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants