fix: selecting multiple blocks and dragging will show multiple placeholders #7089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
Your org has enabled the Graphite merge queue for merging into masterAdd the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
akumatus
force-pushed
the
fix/select-blocks-show-multi-placeholder
branch
from
72cc081
to
f5d8743
Compare
Saul-Mirone
reviewed
May 17, 2024
| @@ -103,11 +107,15 @@ export class ParagraphBlockComponent extends BlockElement< | |||
| ) | |||
| return; | |||
|
|
|||
| const selection = this.host.selection.value[0]; | |||
There was a problem hiding this comment.
Better to use selection.find('text')
There was a problem hiding this comment.
Thanks for your comment! Code updated.
akumatus
force-pushed
the
fix/select-blocks-show-multi-placeholder
branch
from
f5d8743
to
c460ef3
Compare
Saul-Mirone
reviewed
May 17, 2024
| @@ -103,11 +107,15 @@ export class ParagraphBlockComponent extends BlockElement< | |||
| ) | |||
| return; | |||
|
|
|||
| const selection = this.host.selection.find('text'); | |||
| const isCollapsed = | |||
| selection instanceof TextSelection ? selection.isCollapsed : false; | |||
There was a problem hiding this comment.
Since you use find method, you won't need to check the type of it. Also, isCollapsed is a method, not a property.
So it can be replaced by selection?.isCollapsed() ?? false.
There was a problem hiding this comment.
Got it! I will update this change in another PR, thanks for your advice.
Saul-Mirone
approved these changes
May 18, 2024
Merge activity
|
…olders (#7089) ### What changed? - the placeholder will be visible, only if the selection is text selection and collapsed - add e2e test Fix affine-design/issue/BS-312. | Before | After | | ---- | ---- | |  | | ### How to test? Test the paragraph block in various states like editing, selecting, etc. Ensure the placeholder visibility is as expected. ---
Saul-Mirone
force-pushed
the
fix/select-blocks-show-multi-placeholder
branch
from
ee14022
to
2a4f809
Compare
|){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Fix affine-design/issue/BS-312.
How to test?
Test the paragraph block in various states like editing, selecting, etc. Ensure the placeholder visibility is as expected.