Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix?] End interactions before switching page #3771

Merged
merged 2 commits into from
May 20, 2024

Conversation

ds300
Copy link
Collaborator

@ds300 ds300 commented May 17, 2024

Looking at #3762 it seemed to have been caused by calling setCurrentPage during a select.editing_shape interaction. I wonder whether we should trigger a cancel event before switching pages in case this happens?

closes #3762

Change Type

  • sdk — Changes the tldraw SDK
  • dotcom — Changes the tldraw.com web app
  • docs — Changes to the documentation, examples, or templates.
  • vs code — Changes to the vscode plugin
  • internal — Does not affect user-facing stuff
  • bugfix — Bug fix
  • feature — New feature
  • improvement — Improving existing features
  • chore — Updating dependencies, other boring stuff
  • galaxy brain — Architectural changes
  • tests — Changes to any test code
  • tools — Changes to infrastructure, CI, internal scripts, debugging tools, etc.
  • dunno — I don't know

Test Plan

  1. Add a step-by-step description of how to test your PR here.
  • Unit Tests
  • End to end tests

Release Notes

  • Add a brief release note for your PR here.

@ds300 ds300 requested a review from steveruizok May 17, 2024 13:43
@huppy-bot huppy-bot bot added bugfix Fixes a bug of some kind sdk Affects the tldraw sdk labels May 17, 2024
Copy link

vercel bot commented May 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
examples ✅ Ready (Inspect) Visit Preview May 17, 2024 2:06pm
1 Ignored Deployment
Name Status Preview Updated (UTC)
tldraw-docs ⬜️ Ignored (Inspect) May 17, 2024 2:06pm

@ds300 ds300 changed the title [bugfix?] Cancel interactions before switching page [bugfix?] End interactions before switching page May 17, 2024
@ds300 ds300 mentioned this pull request May 17, 2024
1 task
@ds300 ds300 added this pull request to the merge queue May 20, 2024
Merged via the queue into main with commit 2cf8104 May 20, 2024
10 checks passed
@ds300 ds300 deleted the david/cancel-interactions-on-page-switch branch May 20, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Fixes a bug of some kind sdk Affects the tldraw sdk
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Expected an editing shape!
2 participants