Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pages*: make "See also" conform to the new syntax (#12756) #12354

Merged
merged 6 commits into from
Jun 3, 2024

Conversation

vitorhcl
Copy link
Member

These pages are not following the "See also" standard ("See also: COMMAND_NAME").

@github-actions github-actions bot added the page edit Changes to an existing page(s). label Feb 24, 2024
Copy link
Member

@kbdharun kbdharun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution.

LGTM, after the above suggestion.

pages/common/age.md Outdated Show resolved Hide resolved
@sebastiaanspeck
Copy link
Member

@vitorhcl any update on this?

@vitorhcl
Copy link
Member Author

vitorhcl commented May 3, 2024

@vitorhcl any update on this?

The discussion moved to the ipcs PR.

@sebastiaanspeck
Copy link
Member

@vitorhcl any update on this?

The discussion moved to the ipcs PR.

Which is merged

pages/common/age.md Outdated Show resolved Hide resolved
pages/common/git-fsck.md Outdated Show resolved Hide resolved
pages/common/nix3-build.md Outdated Show resolved Hide resolved
pages/common/nix3-registry.md Outdated Show resolved Hide resolved
pages/common/nix3-run.md Outdated Show resolved Hide resolved
pages/common/nix3-search.md Outdated Show resolved Hide resolved
pages/linux/mount.ddi.md Outdated Show resolved Hide resolved
pages/common/age-keygen.md Outdated Show resolved Hide resolved
pages/common/nix3-shell.md Outdated Show resolved Hide resolved
@sebastiaanspeck
Copy link
Member

@vitorhcl sending a friendly reminder

@sebastiaanspeck sebastiaanspeck added the waiting Issues/PRs with Pending response by the author. label Jun 2, 2024
Co-authored-by: K.B.Dharun Krishna <kbdharunkrishna@gmail.com>
@github-actions github-actions bot removed the waiting Issues/PRs with Pending response by the author. label Jun 3, 2024
@vitorhcl vitorhcl requested a review from spageektti as a code owner June 3, 2024 17:26
@vitorhcl vitorhcl changed the title pages*: remove tldr command from "See also" pages*: make "See also" conform to #12756's syntax Jun 3, 2024
@vitorhcl vitorhcl changed the title pages*: make "See also" conform to #12756's syntax pages*: make "See also" conform to the new syntax (#12756) Jun 3, 2024
@vitorhcl
Copy link
Member Author

vitorhcl commented Jun 3, 2024

@vitorhcl sending a friendly reminder

Hi @sebastiaanspeck, I was so busy these days, thank you for pinging me :) I hope I can contribute to the project with some frequency again.

This PR is ready for review now.

pages/common/rustup-toolchain.md Outdated Show resolved Hide resolved
Co-authored-by: Lena <126529524+acuteenvy@users.noreply.github.com>
@tldr-bot

This comment was marked as resolved.

@spageektti spageektti merged commit 4f75ffc into tldr-pages:main Jun 3, 2024
4 checks passed
@vitorhcl vitorhcl deleted the remove-tldr-from-see-also branch June 4, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
page edit Changes to an existing page(s).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants