os.FindProcess, process.Release #4218
Merged
+58
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leongross
force-pushed
the
os/FindProcess
branch
2 times, most recently
from
b27bafa
to
dd061d8
Compare
leongross
force-pushed
the
os/FindProcess
branch
2 times, most recently
from
91b9c03
to
2f2caa6
Compare
leongross
force-pushed
the
os/FindProcess
branch
2 times, most recently
from
01d2922
to
9fa36f7
Compare
Merged
|
To me it looks like these errors are unrelated to the code this patch covers. Any proposal on how to proceed here @aykevl ? |
Signed-off-by: leongross <leon.gross@9elements.com>
Signed-off-by: leongross <leon.gross@9elements.com>
|
@aykevl any idea what's the problem here? |
|
seems to be blocked by #4206 |
|
It's a race that only happens sometimes. I've restarted the test. |
Signed-off-by: leongross <leon.gross@9elements.com>
|
@aykevl I guess we won the ci race, let's merge this :) |
|
Now merging, thanks for the addition @leongross and to @aykevl for review. Now merging. |
|
thanks a lot @deadprogram! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implementation of
os.FindProcessprovides minimal functionality while being aligned to the process design pattern oftinygo.