Remove dead code #6934
Merged
Remove dead code #6934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabriziomello
force-pushed
the
remove_dead_code
branch
2 times, most recently
from
bf9a803
to
a79ac87
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6934 +/- ##
==========================================
+ Coverage 80.06% 81.66% +1.59%
==========================================
Files 190 198 +8
Lines 37181 36836 -345
Branches 9450 9634 +184
==========================================
+ Hits 29770 30082 +312
+ Misses 2997 2873 -124
+ Partials 4414 3881 -533 ☔ View full report in Codecov by Sentry. |
fabriziomello
force-pushed
the
remove_dead_code
branch
from
a79ac87
to
939dc20
Compare
fabriziomello
added
the
tech-debt
fabriziomello
commented
May 20, 2024
Comment on lines
-35
to
-36
| extern TSDLLEXPORT ArrayType *ts_array_create_from_list_bool(List *values); | ||
| extern TSDLLEXPORT ArrayType *ts_array_create_from_list_text(List *values); |
There was a problem hiding this comment.
@svenklemm this code was introduced by you in #6549 but looks like it is not used anymore!
svenklemm
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disable-check: force-changelog-file