Remove unneeded Sort over Sort #6893
Open
+788
−1,544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add ANALYZE. To keep the desired MergeAppend plans, we also have to add a LIMIT everywhere so that the MergeAppend is chosen based on its lower startup cost. Otherwise the plain Sort over Append will be chosen because for small tables its cost is less.
Add ANALYZE after compression. The plan changes are expected, SeqScans are preferred over IndexScans and Sort over MergeAppend for small tables.
We would add extra Sort nodes when adjusting the children of space partitioning MergeAppend under ChunkAppend. This is not needed because MergeAppend plans add the required Sort themselves, and in general no adjustment seems to be required for the MergeAppend children specifically there.
This reverts commit f50947e.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6893 +/- ##
==========================================
+ Coverage 80.06% 81.54% +1.47%
==========================================
Files 190 199 +9
Lines 37181 36851 -330
Branches 9450 9642 +192
==========================================
+ Hits 29770 30050 +280
+ Misses 2997 2851 -146
+ Partials 4414 3950 -464 ☔ View full report in Codecov by Sentry. |
svenklemm
reviewed
Jun 6, 2024
| @@ -134,6 +134,7 @@ set(SOLO_TESTS | |||
| cagg_invalidation | |||
| move | |||
| reorder | |||
| transparent_decompression-${PG_VERSION_MAJOR} | |||
There was a problem hiding this comment.
Why do we need this in SOLO_TESTS?
There was a problem hiding this comment.
Just a debugging leftover, I'll remove it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We would add extra Sort nodes when adjusting the children of space
partitioning MergeAppend under ChunkAppend. This is not needed because
MergeAppend plans add the required Sort themselves, and in general no
adjustment seems to be required for the MergeAppend children
specifically there.
Disable-check: force-changelog-file