Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some flakiness in transparent_decompression test #6892

Merged
merged 16 commits into from
Jun 4, 2024

Conversation

akuzm
Copy link
Member

@akuzm akuzm commented May 7, 2024

Add ANALYZE after compression. The plan changes are expected, SeqScans are preferred over IndexScans and Sort over MergeAppend for small tables.

Disable-check: force-changelog-file

Copy link

codecov bot commented May 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.49%. Comparing base (59f50f2) to head (fae1d37).
Report is 193 commits behind head on main.

Current head fae1d37 differs from pull request most recent head e05fbbf

Please upload reports for the commit e05fbbf to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6892      +/-   ##
==========================================
+ Coverage   80.06%   81.49%   +1.42%     
==========================================
  Files         190      198       +8     
  Lines       37181    36484     -697     
  Branches     9450     9528      +78     
==========================================
- Hits        29770    29731      -39     
+ Misses       2997     2820     -177     
+ Partials     4414     3933     -481     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@antekresic
Copy link
Contributor

Any reason not to merge this? Seems like it would improve things.

@akuzm
Copy link
Member Author

akuzm commented May 27, 2024

Any reason not to merge this? Seems like it would improve things.

There's still some flakiness that I'm investigating in #6893

So this means this PR is probably going to have some more changes. I plan to merge it first, and then merge the above fix, so that it's more clear what it's changing.

@akuzm akuzm enabled auto-merge (squash) June 4, 2024 10:11
@akuzm akuzm added force-auto-backport Automatically backport this PR or fix of this issue, even if it's not marked as "bug" labels Jun 4, 2024
@akuzm akuzm merged commit cecf2f9 into timescale:main Jun 4, 2024
38 of 41 checks passed
@akuzm akuzm deleted the transparent-flaky branch June 4, 2024 10:11
github-actions bot pushed a commit that referenced this pull request Jun 4, 2024
Add ANALYZE after compression. The plan changes are expected, SeqScans
are preferred over IndexScans and Sort over MergeAppend for small
tables.

(cherry picked from commit cecf2f9)
akuzm added a commit that referenced this pull request Jun 4, 2024
Add ANALYZE after compression. The plan changes are expected, SeqScans
are preferred over IndexScans and Sort over MergeAppend for small
tables.

(cherry picked from commit cecf2f9)
timescale-automation pushed a commit that referenced this pull request Jun 4, 2024
Add ANALYZE after compression. The plan changes are expected, SeqScans
are preferred over IndexScans and Sort over MergeAppend for small
tables.

(cherry picked from commit cecf2f9)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backported-2.15.x force-auto-backport Automatically backport this PR or fix of this issue, even if it's not marked as "bug"
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants