Fix ios fullscreen #795
Open
Fix ios fullscreen #795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gultyayev
force-pushed
the
fix-ios-fullscreen
branch
from
dc6a3d3
to
58b0ff3
Compare
|
Check fails seem to be unrelated to my changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes fullscreen animation
The main problem here, it seems, is that flexible margins were used on top of the container. This, in conjunction with flexibleWith & flexibleHeight, resulted in a non-fullscreen container which has a background. The AnimationView has the margins and they successfully center the animation within the fullscreen container, now).
Fixes ignored background color
Before, Light and Dark modes on iOS 12+ fell back to a hardcoded value instead of trying to fall back to the non-suffixed value, first. The PR fixes this by assigning an empty string. If no
BackgroundColoris present, then the next check for.isEmptywill fire and a hardcoded fallback value will be used.Removed orientation observer
Flexible margins seem to adjust the position of the animation automatically. So, we can remove the unneeded listener.
Closes #794