Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

log_backup: fix panic when encountered error during resuming (#17021) #17026

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #17021

What is changed and how it works?

Issue Number: Close #17020

What's Changed:

Spawn thread from the thread pool directly. (Instead of the thread local runtime handle.)

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Release note

Fixed a bug that might cause TiKV panic when resuming a PiTR task and the connection to PD isn't stable enought.

close tikv#17020

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Copy link
Contributor

ti-chi-bot bot commented May 16, 2024

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Leavrth
  • YuJuncen

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

Signed-off-by: hillium <yujuncen@pingcap.com>
@ti-chi-bot ti-chi-bot bot added size/M and removed size/L labels Jun 3, 2024
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Status: PR - There is already 1 approval label Jun 3, 2024
@ti-chi-bot ti-chi-bot bot added status/LGT2 Status: PR - There are already 2 approvals and removed status/LGT1 Status: PR - There is already 1 approval labels Jun 4, 2024
@glorv
Copy link
Contributor

glorv commented Jun 4, 2024

/test

Copy link
Contributor

ti-chi-bot bot commented Jun 4, 2024

@glorv: The /test command needs one or more targets.
The following commands are available to trigger optional jobs:

  • /debug pull-unit-test

In response to this:

/test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@glorv
Copy link
Contributor

glorv commented Jun 4, 2024

/test

Copy link
Contributor

ti-chi-bot bot commented Jun 4, 2024

@glorv: The /test command needs one or more targets.
The following commands are available to trigger optional jobs:

  • /debug pull-unit-test

In response to this:

/test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@glorv
Copy link
Contributor

glorv commented Jun 5, 2024

/merge

Copy link
Contributor

ti-chi-bot bot commented Jun 5, 2024

@glorv: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link
Contributor

ti-chi-bot bot commented Jun 5, 2024

This pull request has been accepted and is ready to merge.

Commit hash: ed27edb

@ti-chi-bot ti-chi-bot bot added the status/can-merge Status: Can merge to base branch label Jun 5, 2024
@ti-chi-bot ti-chi-bot bot merged commit 7ece2ff into tikv:release-6.5 Jun 5, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. dco-signoff: yes release-note size/M status/can-merge Status: Can merge to base branch status/LGT2 Status: PR - There are already 2 approvals type/cherry-pick-for-release-6.5
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants