Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#8538: Support multi-producer single-consumer for Async Worke Queue #8625

Merged
merged 2 commits into from
May 21, 2024
Merged

#8538: Support multi-producer single-consumer for Async Worke Queue #8625

merged 2 commits into from
May 21, 2024

Conversation

tt-asaigal
Copy link
Contributor

  • Add runtime flag and API for toggling between lock_free and lock_based queue modes
  • Add ttnn cpp test for example usage

TT-billteng
TT-billteng requested changes May 18, 2024
View reviewed changes
Copy link
Collaborator

@TT-billteng TT-billteng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't think you need to bump UMD

@tt-rkim
Copy link
Collaborator

tt-rkim commented May 21, 2024

In addition to post commit pls run

  • fast dispatch nightly (SD is non-det hanging on WH only)
  • device perf (@mo-tenstorrent should fix soon)
  • multi chip unit tests

@tt-asaigal
Copy link
Contributor Author

In addition to post commit pls run

  • fast dispatch nightly (SD is non-det hanging on WH only)
  • device perf (@mo-tenstorrent should fix soon)
  • multi chip unit tests

All workflows except for device perf pass, which has the same failures as main.

@mo-tenstorrent
Copy link
Contributor

In addition to post commit pls run

  • fast dispatch nightly (SD is non-det hanging on WH only)
  • device perf (@mo-tenstorrent should fix soon)
  • multi chip unit tests

All workflows except for device perf pass, which has the same failures as main.

Waiting on rebase static checks, fix will be merged right after

@mo-tenstorrent
Copy link
Contributor

@tt-asaigal Fix is merged can you try device perf again

@tt-asaigal
Copy link
Contributor Author

@tt-asaigal Fix is merged can you try device perf again

running

vtangTT and others added 2 commits May 21, 2024 16:34
@vtangTT @tt-asaigal
#8538: Support multi-producer single-consumer for Async Worke Queue
cfd2e5e 
  - Add runtime flag and API for toggling between lock_free and
    lock_based queue modes
  - Add ttnn cpp test for example usage
@tt-asaigal
#0: Allow non-parent threads to push to worker queue. Add option for …
f2c960b 
…non-blocking reads
@tt-asaigal
Copy link
Contributor Author

@tt-asaigal Fix is merged can you try device perf again

running

Confirmed with @mo-tenstorrent that the device perf regressions look okay.

@tt-asaigal tt-asaigal merged commit 38145ff into main May 21, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davorchap davorchap davorchap approved these changes

@cfjchu cfjchu cfjchu approved these changes

@pgkeller pgkeller pgkeller approved these changes

@TT-billteng TT-billteng TT-billteng approved these changes

@eyonland eyonland Awaiting requested review from eyonland eyonland is a code owner

@arakhmati arakhmati Awaiting requested review from arakhmati arakhmati is a code owner

@xanderchin xanderchin Awaiting requested review from xanderchin xanderchin is a code owner

@tt-rkim tt-rkim Awaiting requested review from tt-rkim

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@tt-asaigal @TT-billteng @tt-rkim @mo-tenstorrent @davorchap @cfjchu @pgkeller @vtangTT