#8018: Adding rotary_embedding to ttnn #8616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cfjchu
reviewed
May 17, 2024
cfjchu
approved these changes
May 17, 2024
ayerofieiev-tt
approved these changes
May 17, 2024
eyonland
force-pushed
the
ttnn-8018-rotary-embedding
branch
2 times, most recently
from
83c1147
to
2c1fce2
Compare
eyonland
commented
May 20, 2024
|
|
||
| rotary_embedding(input_tensor: ttnn.Tensor, cos_cache: ttnn.Tensor, sin_cache: ttnn.Tensor, token_index: int, memory_config: MemoryConfig) -> ttnn.Tensor | ||
| pt_out = apply_rotary_pos_emb(x, cos_cached, sin_cached, token_idx) | ||
| return pt_out | ||
|
|
There was a problem hiding this comment.
@tt-aho , would you take a close look at the _golden_function here in pytorch that is intended to reproduce the rotary_embedding op we have?
There was a problem hiding this comment.
This looks correct for the case where token_idx is provided
eyonland
force-pushed
the
ttnn-8018-rotary-embedding
branch
from
a8bec8d
to
2a69c4d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.