#5044: Add optional output tensor for backward ops #8592
+270
−38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bharane-ab
requested review from
umadevimcw,
ruthreshx,
tt-aho,
VirdhatchaniKN,
Aswinmcw,
KalaivaniMCW,
mouliraj-mcw,
mcw-anasuya,
arakhmati and
eyonland
eyonland
reviewed
May 20, 2024
bharane-ab
force-pushed
the
bharane/backward_optional_output
branch
4 times, most recently
from
5fbe6c7
to
e82db03
Compare
eyonland
reviewed
May 22, 2024
eyonland
requested changes
May 22, 2024
tests/tt_eager/python_api_testing/unit_testing/backward_ops/test_backward_addcdiv.py
Outdated
Show resolved
Hide resolved
tests/tt_eager/python_api_testing/unit_testing/backward_ops/test_backward_addcmul.py
Outdated
Show resolved
Hide resolved
dongjin-na
reviewed
May 26, 2024
| output_tensor.at(0) = std::nullopt; | ||
| } | ||
| if(are_required_outputs.at(1)){ | ||
| output_tensor.at(1) = mul(grad, tensor2, std::nullopt, output_mem_config); |
There was a problem hiding this comment.
Please refer to this comment for more details.
bharane-ab
force-pushed
the
bharane/backward_optional_output
branch
from
e82db03
to
7e51017
Compare
bharane-ab
force-pushed
the
bharane/backward_optional_output
branch
from
7e51017
to
a68f91a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add optional output tensor support for backward op addcmul.
Primary issue : #5044